Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire nightly jdk19 builds and replace with jdk20 #628

Conversation

adamfarley
Copy link
Contributor

Also includes a few formatting changes for tidiness.

Also includes a few formatting changes for tidiness.

Signed-off-by: Adam Farley <[email protected]>
@adamfarley adamfarley self-assigned this Feb 27, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,19"

@github-actions github-actions bot added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts documentation generation Issues that provide enhancements or fixes to the job generators ghActions jenkins-pipeline testing labels Feb 27, 2023
@adamfarley
Copy link
Contributor Author

@steelhead31 - Heya Scott. I think it's a good idea to add a requirement for this sort of PR into the release checklist as a post-release event, to cover releases that are a quarterly CPU containing a short-term release with no subsequent CPUs (e.g. the January release in regard to jdk19).

What do you think?

@steelhead31
Copy link
Contributor

@steelhead31 - Heya Scott. I think it's a good idea to add a requirement for this sort of PR into the release checklist as a post-release event, to cover releases that are a quarterly CPU containing a short-term release with no subsequent CPUs (e.g. the January release in regard to jdk19).

What do you think?

Definitely a good idea, I've got a number of changes to make to the release checklist, which Im planning to do tomorrow, alongside a number of other documentation changes following the last CPU, so I'll be sure to include this!

@karianna karianna merged commit 5565394 into adoptium:master Feb 27, 2023
karianna added a commit that referenced this pull request Feb 27, 2023
@adamfarley adamfarley changed the title WIP: Retire nightly jdk19 builds and replace with jdk20 Retire nightly jdk19 builds and replace with jdk20 Feb 28, 2023
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
Also includes a few formatting changes for tidiness.

Signed-off-by: Adam Farley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts documentation generation Issues that provide enhancements or fixes to the job generators ghActions jenkins-pipeline testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants